Allow per-stage briefing grid colors #6448
Merged
+94
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookieejedi
added
enhancement
BMagnu
requested changes
Dec 18, 2024
BMagnu
requested changes
Dec 22, 2024
There was a problem hiding this comment.
Changes seem good.
One thing to note which I forgot to tag in the first review is that this also needs to correctly perform checks for version-specific data on-save to correctly set the minimum required FSO-version in the PR. See line 3159 of FRED's missionsave.cpp
Done |
BMagnu
requested changes
Jan 2, 2025
BMagnu
approved these changes
Jan 2, 2025
BMagnu
requested changes
Jan 4, 2025
BMagnu
approved these changes
Jan 4, 2025
MjnMixael
force-pushed
the
briefing_stage_grid_color
branch
3 times, most recently
from
5b39e52 to
408fd08
Compare
MjnMixael
force-pushed
the
briefing_stage_grid_color
branch
from
408fd08 to
17e4634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting a custom grid color for each briefing stage with
$grid_color: (r, g, b, a)For now there's no UI because this is decidedly niche and would be much easier to do in qt with a full color picker.